use QPointer in QTimer::singleShot to prevent use-after-free#1
Open
use QPointer in QTimer::singleShot to prevent use-after-free#1
Conversation
The QTimer::singleShot in Property::setModel used model_ as context but captured 'this' (Property*). If the Property was destroyed before the timer fired, this caused a use-after-free crash in the propertyHiddenChanged signal emission. Fix by capturing QPointer guarded 'this'. Semantic stays the same - Qt automatically cancels the timer if the model_ is destroyed but QPointer on Property provides extra protection. The bug manifests as a segfault in MoveIt Setup Assistant when loading robot models, crashing in PropertyTreeModel::propertyHiddenChanged(). Some MoveIt2 crashes seem relevant: - 3546 - 3553 - 3541 Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QTimer::singleShot in Property::setModel used model_ as context but captured 'this' (Property*). If the Property was destroyed before the timer fired, this caused a use-after-free crash in the propertyHiddenChanged signal emission.
Fix by capturing QPointer guarded 'this'. Semantic stays the same - Qt automatically cancels the timer if the model_ is destroyed but QPointer on Property provides extra protection.
The bug manifests as a segfault in MoveIt Setup Assistant when loading robot models, crashing in PropertyTreeModel::propertyHiddenChanged().
Some MoveIt2 crashes seem relevant: