chore(random): Review build configuration by tassoevan · Pull Request #37901 · RocketChat/Rocket.Chat

tassoevan · 2025-12-19T20:22:46Z

Proposed changes (including videos or screenshots)

This pull request cleans up and simplifies the configuration for the packages/random package. The main changes involve removing unnecessary dependencies and configuration files related to Babel and Jest, as well as updating TypeScript configuration to streamline the build process.

Configuration cleanup and simplification:

Removed Babel configuration by deleting babel.config.js and removing related dependencies from package.json, since Babel is no longer needed for this package. [1] [2]
Removed Jest-specific settings from .eslintrc.json, simplifying the ESLint configuration.
Cleaned up TypeScript configuration by moving the outDir setting from tsconfig.json to tsconfig.build.json and removing strictNullChecks for consistency with the base config. [1] [2]

Build process improvements:

Updated tsconfig.build.json to output build artifacts to the dist directory and exclude only TypeScript spec files, ensuring a cleaner build output.

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Chores
- Removed several development/tooling dependencies and related lint/test config from the random package.
- Simplified linting and removed test globals from the development config.
- Removed the package-level Babel setup.
- Adjusted TypeScript build settings: build output now targets a dist directory and project compilation strictness was relaxed.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

dionisio-bot · 2025-12-19T20:22:48Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-19T20:22:50Z

⚠️ No Changeset found

Latest commit: ee95947

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-19T20:23:09Z

Walkthrough

Removed per-package Babel config and Babel-related devDependencies, removed TypeScript ESLint devDependencies, removed Jest plugin/globals from ESLint config, and adjusted TypeScript configs (added outDir in tsconfig.build.json, changed excludes, removed outDir and strictNullChecks from tsconfig.json).

Changes

Cohort / File(s)	Summary
ESLint Configuration `packages/random/.eslintrc.json`	Removed Jest plugin entry and `env: { "jest/globals": true }`; left only base extends and `ignorePatterns`.
Babel Configuration `packages/random/babel.config.js`	Deleted file (previously exported `presets: ['@babel/preset-env']`).
Package Dependencies `packages/random/package.json`	Removed devDependencies: `@babel/core`, `@babel/preset-env`, `@typescript-eslint/eslint-plugin`, `@typescript-eslint/parser`.
TypeScript Build Configuration `packages/random/tsconfig.build.json`	Added `compilerOptions.outDir = "dist"` and removed `*/.spec.js` from `exclude` (now only `*/.spec.ts`).
TypeScript Root Configuration `packages/random/tsconfig.json`	Removed `outDir` and `strictNullChecks` from `compilerOptions`; retained `rootDir` and `include`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Check CI/build pipeline for any assumptions about per-package Babel or removed devDependencies.
Verify linting across repo after removing TypeScript ESLint plugin from this package.
Confirm TypeScript emit paths and exclude patterns align with monorepo build tools.

Possibly related PRs

chore(federation-matrix): Review build configuration #37858 — similar removal of babel.config and Babel devDependencies plus tsconfig/outDir changes across packages.
chore(ui-video-conf): Review build configuration #37586 — removes per-package Babel config and @babel/core devDependency in other packages.
chore(rest-typings): Review build configuration #37618 — removes Jest-specific ESLint config from package-level .eslintrc.json files.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

ggazzo

Poem

🐰 Hops and tweaks, configs unwind,
Babel folded, lint rules refined.
Jest globals hop away,
tsconfig shifts to a simpler day.
🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore(random): Review build configuration' accurately describes the main objective of the pull request, which is to review and simplify the build and tooling configuration for the packages/random package.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/random-build-configuration

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 966443c and ee95947.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (5)

packages/random/.eslintrc.json (0 hunks)
packages/random/babel.config.js (0 hunks)
packages/random/package.json (0 hunks)
packages/random/tsconfig.build.json (1 hunks)
packages/random/tsconfig.json (0 hunks)

💤 Files with no reviewable changes (4)

packages/random/.eslintrc.json
packages/random/package.json
packages/random/tsconfig.json
packages/random/babel.config.js

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.{ts,tsx,js} : Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests

📚 Learning: 2025-12-10T21:00:54.909Z

Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.

Applied to files:

packages/random/tsconfig.build.json

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.spec.ts : Use `.spec.ts` extension for test files (e.g., `login.spec.ts`)

Applied to files:

packages/random/tsconfig.build.json

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.{ts,tsx,js} : Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests

Applied to files:

packages/random/tsconfig.build.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🔇 Additional comments (2)

packages/random/tsconfig.build.json (2)

4-4: LGTM: Build output location properly configured.

Moving outDir to the build-specific configuration is appropriate separation of concerns, and dist is a conventional location for compiled artifacts.

11-11: No action needed. The **/*.spec.js exclusion was correctly removed because no JavaScript test files exist in this package—only TypeScript test files (*.spec.ts). The change is intentional and aligns with the package's exclusive use of TypeScript.

Likely an incorrect or invalid review comment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-19T21:07:19Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	-287B
queue-worker-service	132MiB	132MiB	+908B
ddp-streamer-service	126MiB	126MiB	+252B
account-service	113MiB	113MiB	+206KiB
authorization-service	111MiB	111MiB	-542B
stream-hub-service	111MiB	111MiB	+147B
presence-service	111MiB	111MiB	-334B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 06:10", "12/20 06:31 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 26 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37901
Baseline: develop
Timestamp: 2025-12-20 06:31:33 UTC
Historical data points: 26

Updated: Sat, 20 Dec 2025 06:31:33 GMT

codecov · 2025-12-20T06:57:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.72%. Comparing base (5836726) to head (ee95947).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37901      +/-   ##
===========================================
+ Coverage    67.69%   67.72%   +0.02%     
===========================================
  Files         3476     3476              
  Lines       113895   113895              
  Branches     20956    20956              
===========================================
+ Hits         77098    77132      +34     
+ Misses       34609    34585      -24     
+ Partials      2188     2178      -10

Flag	Coverage Δ
e2e	`57.25% <ø> (+0.09%)`	⬆️
e2e-api	`44.07% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tassoevan added this to the 7.14.0 milestone Dec 19, 2025

tassoevan requested a review from a team December 19, 2025 20:22

chore(random): Review build configuration

ee95947

tassoevan force-pushed the chore/random-build-configuration branch from 103bdf2 to ee95947 Compare December 20, 2025 05:55

ggazzo approved these changes Dec 20, 2025

View reviewed changes

ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 20, 2025

ggazzo merged commit 572c963 into develop Dec 20, 2025
52 checks passed

ggazzo deleted the chore/random-build-configuration branch December 20, 2025 16:19

coderabbitai bot mentioned this pull request Dec 22, 2025

chore(core-services): Review build configuration #37925

Merged

gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026

chore(random): Review build configuration (RocketChat#37901)

6d68e8c

dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026

coderabbitai bot mentioned this pull request Feb 4, 2026

fix(models): escape external inputs before RegExp construction in Liv… #38490

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore(random): Review build configuration#37901

chore(random): Review build configuration#37901
ggazzo merged 1 commit intodevelopfrom
chore/random-build-configuration

tassoevan commented Dec 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Dec 19, 2025

Uh oh!

changeset-bot bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

tassoevan commented Dec 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 19, 2025

Uh oh!

changeset-bot bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

codecov bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tassoevan commented Dec 19, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Dec 19, 2025 •

edited

Loading

coderabbitai bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

codecov bot commented Dec 20, 2025 •

edited

Loading