chore!: add OTR migration

[juliajforesti]

ARCH-1600

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Chores
  • Removed legacy OTR configuration settings as part of system maintenance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: d47e3e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

A new database migration (v335) is added to remove two OTR-related settings ('OTR_Enable', 'OTR_Count') from the Settings collection. The migration module is registered in the migration loading sequence via an import statement.

Changes

Cohort / File(s)	Summary
Migration Infrastructure apps/meteor/server/startup/migrations/index.ts	Added import for v335 migration module to extend the migration loading sequence
OTR Settings Cleanup apps/meteor/server/startup/migrations/v335.ts	New migration file that removes OTR_Enable and OTR_Count settings documents from the Settings collection using deleteMany operation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ggazzo

Poem

🐰 Hop, hop, farewell to OTR so dear,
Settings cleaned with a database cheer,
v335 migration takes the lead,
Removing what's no longer need! 🗑️

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore!: add OTR migration' directly describes the main change: adding a new OTR migration to the codebase.
Linked Issues check	✅ Passed	The PR addresses ARCH-1600 (Remove OTR feature) by implementing a database migration that removes OTR settings (OTR_Enable and OTR_Count), fulfilling the core requirement to remove the OTR feature.
Out of Scope Changes check	✅ Passed	All changes are directly related to the OTR migration: adding the migration file and importing it into the migrations index, with no unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch regression/otr-migration

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 45e5219 and d47e3e0.

📒 Files selected for processing (2)

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v335.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/meteor/server/startup/migrations/index.ts

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• apps/meteor/server/startup/migrations/v335.ts

🧠 Learnings (1)

📚 Learning: 2025-09-19T15:15:04.642Z

Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

• apps/meteor/server/startup/migrations/v335.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

🔇 Additional comments (2)

apps/meteor/server/startup/migrations/v335.ts (2)

1-3: LGTM!

The imports are appropriate for a migration that removes settings from the database.

---

5-11: Migration is safe to proceed.

Verification confirms that OTR_Enable and OTR_Count are not referenced anywhere in the codebase, so removing them will not cause runtime errors. The migration correctly uses deleteMany for idempotent removal.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.66%. Comparing base (d7043fd) to head (d47e3e0).

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #37958      +/-   ##
=================================================
+ Coverage          70.64%   70.66%   +0.01%     
=================================================
  Files               3144     3144              
  Lines             108679   108679              
  Branches           19461    19552      +91     
=================================================
+ Hits               76779    76796      +17     
+ Misses             29908    29890      -18     
- Partials            1992     1993       +1     

Flag	Coverage Δ
unit	71.78% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.