Closed
Conversation
--danich
danichcr72
commented
May 22, 2025
|
|
||
| log_info "Pulling latest container images." | ||
| if ! output=$(run_with_timeout 300 docker compose pull 2>&1); then | ||
| if [ $use_timeout -eq 1 ] && ! output=$(run_with_timeout 300 $DOCKER_CMD compose pull 2>&1); then |
Contributor
Author
There was a problem hiding this comment.
This doesn't work when running inside the macOS installer...
gmackey
reviewed
May 22, 2025
| echo " --http-port PORT Specify custom HTTP port (default: $DEFAULT_HTTP_PORT)" | ||
| echo " --https-port PORT Specify custom HTTPS port (default: $DEFAULT_HTTPS_PORT)" | ||
| echo " --docker-command DOCKER_COMMAND Specify explicit location of the docker command (default: $DEFAULT_DOCKER_CMD)" | ||
| echo " -h, --help Show this help message" |
Contributor
There was a problem hiding this comment.
Should a line in the help be added for use-timeout?
--danich
gmackey
approved these changes
May 22, 2025
landwehrj
reviewed
May 22, 2025
--danich
landwehrj
reviewed
May 22, 2025
--danich
landwehrj
reviewed
May 22, 2025
--danich
landwehrj
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes required for macOS installer.
--danich