Conversation
boot 1 extra container on fallback.
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the template extraction process in the Docker deployment script by prioritizing the use of running containers over creating new ones. The change reduces resource usage by first attempting to copy templates from an already running container before falling back to spinning up a temporary container.
Key changes:
- Implement a two-stage template extraction strategy that checks for running containers first
- Simplify error handling by using informational logging instead of error exits
- Reduce unnecessary container creation when templates can be copied from existing containers
Contributor
Author
|
This should be tested on mac before committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.