Update-bnappbar #47
Open
Update-bnappbar #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dallasbpeters
commented
Oct 13, 2025
dallasbpeters
commented
- Added theme mode toggle in BNAnimatedMenuIcon and support for auto-inserting it in BNAppBar.
- Enhanced BNAppBar with dropdown menus for tabs and improved mobile drawer functionality.
- Normalized tab alignment and spacing, repositioned account Popper, and refined MuiAccordion styles.
- Fixed issues with blank menu items and dividers in dropdowns.
- Added documentation stories for new features and migrated Vite configuration for Storybook testing.
- Added Storybook test configuration using Vitest with Playwright support. - Defined a new project for Storybook tests, enabling browser testing with specified settings. - Included setup files for Vitest integration with Storybook.
- Introduced a theme toggle feature in the BNAnimatedMenuIcon, allowing users to switch between light, dark, and system modes. - Enhanced BNAppBar to conditionally include the theme toggle in the menu items. - Updated BNAppBarDrawer to sanitize menu items - Improved tab dropdown functionality in BNAppBar - Added new props and slot customization options
…ation - Removed unnecessary state management for menu positioning in BNAnimatedMenuIcon. - Updated BNAppBar to directly use processed menu items, eliminating the mobile drawer filter. - Introduced a theme toggle component in BNAppBarDrawer, allowing users to switch themes. - Enhanced menu item rendering logic to support nested items and improved accessibility. - Adjusted styling and layout for better user experience in the app bar drawer.
- Added theme mode toggle in BNAnimatedMenuIcon and support for auto-inserting it in BNAppBar. - Enhanced BNAppBar with dropdown menus for tabs and improved mobile drawer functionality. - Normalized tab alignment and spacing, repositioned account Popper, and refined MuiAccordion styles. - Fixed issues with blank menu items and dividers in dropdowns. - Added documentation stories for new features and migrated Vite configuration for Storybook testing.
There was a problem hiding this comment.
Pull Request Overview
This PR adds theme mode toggle functionality to the BNAppBar component and enhances tab functionality with dropdown menus. It also migrates the Vite configuration to support Storybook testing and refines various UI component styles.
Key changes include:
- Theme toggle integration in BNAnimatedMenuIcon and BNAppBar with auto-insertion support
- Enhanced tab functionality with dropdown menus for desktop and improved mobile drawer behavior
- UI refinements for tab alignment, accordion styles, and menu positioning
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | Migrated from vitest.workspace.js to projects configuration with Storybook testing support |
| src/themes/base/components/MuiAppBar.ts | Added tab normalization styles for consistent alignment and icon spacing |
| src/themes/base/components/MuiAccordion.ts | Enhanced accordion styling with border radius and divider improvements |
| src/stories/CHANGELOG.mdx | Updated changelog with new features, changes, and fixes |
| src/stories/BNAppBar.stories.tsx | Added new stories for theme toggle, dropdown menus, and various scenarios |
| src/components/app-bar/BNAppBarDrawer.tsx | Enhanced drawer with theme toggle component and improved menu item handling |
| src/components/app-bar/BNAppBar.tsx | Added dropdown tab functionality and theme toggle integration |
| src/components/app-bar/BNAnimatedMenuIcon.tsx | Implemented theme toggle using ToggleButtonGroup and improved menu positioning |
| package.json | Version bump to 1.1.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Extracted ThemeToggleItem component in BNAnimatedMenuIcon to prevent unnecessary re-renders. - Refined menu item rendering logic for better accessibility and maintainability.
- Renamed the story from WithMenuSubheaderAndLongMenu to MenuSubheader for clarity. - Reduced the number of menu items from 10 to 5 to streamline the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.