Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Jul 30, 2024

Why?

The google font import for Noto Sans and Noto Serif was not including all the available axes for the variable fonts. This change allows for that and actually simplifies the font face file loaded from google and reduces the size of the payload.

What Changed

  • Update import for Noto Sans to use newer syntax. This allows the width axis to be adjusted via the font-stretch css property
  • Add --op-font-family-alt token set to Noto Serif

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • [ ] Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

Screenshots

Before

Screenshot 2024-07-30 at 6 14 31 PM

After

Screenshot 2024-07-30 at 6 14 53 PM Note: It isn't shown in the image, but the single request is loading both Noto Sans and Noto Serif Screenshot 2024-07-31 at 9 56 38 AM

@Jeremy-Walton Jeremy-Walton requested a review from scriswell July 30, 2024 22:20
@Jeremy-Walton Jeremy-Walton self-assigned this Jul 30, 2024
@linear
Copy link

linear bot commented Jul 30, 2024

@Jeremy-Walton Jeremy-Walton added bug Something isn't working Cleanup Clean up styles Base Tokens Changes to the base tokens labels Jul 30, 2024
@Jeremy-Walton Jeremy-Walton force-pushed the op-168-font-import-issues branch from 6fc1de5 to d426c85 Compare December 14, 2024 21:43
@Jeremy-Walton Jeremy-Walton merged commit 06b6477 into main Dec 14, 2024
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-168-font-import-issues branch December 14, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Base Tokens Changes to the base tokens bug Something isn't working Cleanup Clean up styles

Development

Successfully merging this pull request may close these issues.

3 participants