-
Notifications
You must be signed in to change notification settings - Fork 0
[OP-170] Refactor Simple Components #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremy-Walton
approved these changes
Jan 30, 2025
dominicmacaulay
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking Change
This will cause problems so be sure to indicate that in the release notes
Components
Changes to a component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
OP #170
Why?
In an effort to move away from sass, following a strict BEM structure in needed for Alerts.
What Changed
What changed in this PR?
accordion.scssand docsavatar.scssand docsbreadcrumbs.scssand docspagination.scssand docsspinner.scssand docstooltip.scssand docsswitch.scssand docstab.scssand docstext-pair.scssand docsdivider.scssand docsSanity Check
[ ] Have you updated any usage of changed tokens?[ ] Have you updated the dependency graph with any component changes?