OP-174 Refactor Badge and Tag #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicmacaulay
added
Breaking Change
dominicmacaulay
force-pushed
the
op-174-refactor-badge-and-tag
branch
from
4e48fdb to
e25f116
Compare
Jeremy-Walton
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
[Refactor Badge] (https://linear.app/rolemodelsoftware/issue/OP-174/refactor-badge)
[Refactor Tag] (https://linear.app/rolemodelsoftware/issue/OP-190/refactor-tag)
Why?
We want to restructure our badge and tag components to use the basic css BEM structure.
What Changed
badge.scssandtag.scsstobadge.cssandtag.cssusing BEM structureSanity Check
[ ] Have you updated any usage of changed tokens?[ ] Have you updated the dependency graph with any component changes?