Improve FrameLinkHelper #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justwiebe
approved these changes
Oct 29, 2025
wesrich
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The FrameLinkHelper (generated by the Modal generator) was overly complicated & contained at least 1 bug (required an options hash)
Side Note:
In addition to Generator specs, we should be testing the functionality our generators are providing. That's not always straight forward to do and will often (as was the case here) require separate spec files. As the code owner however, it only makes sense that those tests belong here.
What Changed
Pre-merge checklist
lib/rolemodel_rails/version.rbScreenshots