Skip to content

Convention

Yunseon Choi edited this page May 6, 2021 · 4 revisions

๐Ÿค— Naming

ํŒŒ์ผ๋ช…

  • LAYOUTS : WHAT_WHERE.XML / e.g. activity_main.xml
  • STRINGS : WHERE_DESCRIPTION / e.g. main_intro, all_done
  • DRAWABLES : WHERE_DESCRIPTION_SIZE / e.g. main_background
  • IDS : WHAT_WHERE_DESCRIPTION / e.g. linearylayout_main_fragmentcontainer
  • DIMENSIONS : WHAT_WHERE_DESCRIPTION_SIZE / e.g. keyline_all_text
  • Fagment๋Š” PascalCase๋กœ ์ž‘์„ฑํ•œ๋‹ค. / e.g BookFragment

๋ณ€์ˆ˜๋ช…

  • ๋ณ€์ˆ˜๋ช…์€ ๊ธฐ๋ณธ์ ์œผ๋กœ camelCase๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.
  • ๊ฐ€๋Šฅํ•œ ๋ช…์‚ฌ๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.
  • ๋ณต์ˆ˜์˜ ๊ฒฝ์šฐ ๋ณต์ˆ˜ํ˜• ๋ช…์‚ฌ๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.
  • boolean ํ˜•์„ ๊ฐ–๋Š” ๋ณ€์ˆ˜๋Š” ์•ž์— is๋ฅผ ๋ถ™์ธ๋‹ค.
  • ์•ฝ์–ด๋ฅผ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š”๋‹ค.

ํ•จ์ˆ˜๋ช…

  • ํ•จ์ˆ˜๋ช…์€ ๊ธฐ๋ณธ์ ์œผ๋กœ camelCase๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.
  • ๊ฐ€๋Šฅํ•œ ๋™์‚ฌ๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.
  • ํ•จ์ˆ˜๋ช…์„ ์ถ•์•ฝํ•˜์ง€ ์•Š๋Š”๋‹ค.
  • booleanํ˜•์„ returnํ•˜๋Š” ํ•จ์ˆ˜๋Š” ์•ž์— check๋ฅผ ๋ถ™์ธ๋‹ค.

๐Ÿ™„ Issue Conventions

  • Issue ๋‚ด์šฉ์€ Todo-List ํ˜•์‹์œผ๋กœ ์ž‘์„ฑํ•œ๋‹ค.

๐Ÿ‘Š Commit Message Conventions

  • ์ปค๋ฐ‹ ์‹œ ์•„๋ž˜ ๊ทœ์น™์„ ์ฐธ๊ณ ํ•ด ๋ฉ”์„ธ์ง€๋ฅผ ์ž‘์„ฑํ•˜์ž, ์˜์–ด๋กœ ์ž‘์„ฑํ•  ํ•„์š”๋Š” ์—†๋‹ค.

  • issue-number๋Š” Github์˜ issue๋ฅผ ๋ฐœ๊ธ‰ํ•˜๊ณ , ์ƒ์„ฑ๋œ ๋ฒˆํ˜ธ๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.

[#{issue-number}] feat - (feature)
[#{issue-number}] fix - (bug fix)
[#{issue-number}] refactor - (split package)
[#{issue-number}] docs - (documentation)
[#{issue-number}] style - (formatting, missing semi colons, โ€ฆ)
[#{issue-number}] test - (when adding missing tests)

๐Ÿ˜พ Github branching

  • master
  • dev
  • feature/{issue-number}-{desc..}
  • branch๋Š” camelCase๋กœ ์ž‘์„ฑํ•œ๋‹ค.
  • Pull Request๋Š” Merge ์ „ Reviewer์˜ approve๊ฐ€ ํ•„์š”ํ•˜๋‹ค.
  • feature -> dev -> main

๐Ÿ‘ถ Code

  • Android Lint๋ฅผ ํ™œ์šฉํ•œ๋‹ค.
  • ๋ฒ„๊ทธ๊ฐ€ ์žˆ์œผ๋ฉด ์ปค๋ฐ‹ํ•  ์ˆ˜ ์—†๋‹ค.
  • import๋ฅผ ์ •๊ทœํ™”ํ•œ๋‹ค.

import foo.* (x)
import foo.bar (o)

  • ๋ณ€์ˆ˜ ๋ฒ”์œ„๋Š” ๋ช…ํ™•ํ•˜๊ฒŒ ์ œํ•œํ•œ๋‹ค.
  • ์˜ˆ์™ธ๋ฅผ ๋ฌด์‹œํ•  ๊ฒฝ์šฐ ์ฃผ์„์œผ๋กœ ์ด์œ ๋ฅผ ๋‚จ๊ธด๋‹ค.
  • ๋“ค์—ฌ์“ฐ๊ธฐ๋Š” 4์นธ์œผ๋กœ ํ•œ๋‹ค.