ci(release): improve archive structure and refactor workflow #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous release workflow created archives that extracted their contents directly into the current directory ("tarbombs"). This is not a best practice and is incompatible with tools like `cargo-binstall`.
This commit refactors the release process to fix this by creating a single root directory within each archive (e.g., `dircat-v1.2.3-x86_64.../`) that contains the binary, LICENSE, and README files.
Additional improvements include:
- Upgrading `softprops/action-gh-release` to v2 and enabling `generate_release_notes: true` for automated changelogs.
- Adding a `workflow_dispatch` trigger to allow for manual release creation.
- Adding extensive comments throughout the workflow file to improve clarity and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous release workflow created archives that extracted their contents directly into the current directory ("tarbombs"). This is not a best practice and is incompatible with tools like
cargo-binstall.This commit refactors the release process to fix this by creating a single root directory within each archive (e.g.,
dircat-v1.2.3-x86_64.../) that contains the binary, LICENSE, and README files.Additional improvements include:
softprops/action-gh-releaseto v2 and enablinggenerate_release_notes: truefor automated changelogs.workflow_dispatchtrigger to allow for manual release creation.