Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Jan 14, 2026

Summary

Adds release notes for the v3.40 series (v3.40.0, v3.40.1) and updates the release notes writer configuration rules.

Changes

  • Added docs/update-notes/v3.40.0.mdx
  • Added docs/update-notes/v3.40.1.mdx
  • Added docs/update-notes/v3.40.mdx
  • Updated docs/update-notes/index.md and sidebars.ts
  • Updated release notes writer rules
  • Added release asset static/img/v3.40.0/v3.40.0.png

Important

Adds release notes for v3.40, updates release notes writer configuration, and includes new version in documentation index and sidebars.

  • Release Notes:
    • Added v3.40.0.mdx, v3.40.1.mdx, and v3.40.mdx for version 3.40 release notes.
    • Updated index.md to include links to the new release notes.
    • Updated sidebars.ts to include the new version 3.40 in the navigation.
  • Configuration:
    • Updated release notes writer rules in 1_main_workflow.xml and 2_content_standards.xml to refine image handling and contributor acknowledgments.
  • Assets:
    • Added release asset v3.40.0.png to static/img/v3.40.0/.

This description was created by Ellipsis for 6336290. You can customize this summary. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Jan 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
roo-code-docs Ready Ready Preview, Comment Jan 14, 2026 5:29am

@roomote
Copy link
Contributor

roomote bot commented Jan 14, 2026

Oroocle Clock   See task on Roo Cloud

Review complete. Left a few actionable notes for rules consistency and to avoid edge cases in the hero-image discovery step.

  • Fix release-notes writer markdown templates that include leading-space headings (e.g., ##) and whitespace-only lines
  • In hero image resolution step, add an explicit empty-candidates guard so the workflow does not download .../main/ and accidentally treat HTML as a valid image
  • Update v3.40.0 release notes so contributor acknowledgements follow the new rules (include issue reporter when PR author is excluded)

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph merged commit 8d76b30 into main Jan 14, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 14, 2026
@hannesrudolph hannesrudolph deleted the release-notes/v3.40 branch January 14, 2026 05:32
[Concluding sentence about impact]

> **📚 Documentation**: See [Feature Guide](/path/to/feature) for detailed usage instructions.
## [Feature Name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the markdown templates under major_features/expanded_sections, the headings and paragraphs start with a leading space (for example " ##"), and there are lines that are just a single space. If copied verbatim into MDX, this can prevent headings from being recognized and introduces trailing whitespace. Recommend removing the leading/trailing spaces so templates are valid markdown as-is.

Fix it with Roo Code or mention @roomote and request a fix.


<step number="1b">
<action>Resolve hero image from discovered candidates, falling back to social-share when none exist</action>
<action>Resolve hero image from discovered candidates (no placeholder if none exist)</action>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step 1b notes say to skip hero image download when no candidates were discovered, but the script always does head -n1 and curl even if the candidates file is empty/missing. In that case the URL becomes .../main/ and can still produce a non-empty output (for example an HTML 404 page), which would incorrectly get treated as a valid hero image. Consider adding an explicit -s/empty check for $CANDIDATES_FILE (and optionally verifying HTTP status/content-type) before downloading and writing the frontmatter path.

Fix it with Roo Code or mention @roomote and request a fix.


## Tool-calling compatibility fixes

This release improves compatibility across providers (especially Gemini and OpenAI-compatible backends) by addressing request/response validation edge cases (thanks Idlebrand!). Roo now avoids sending tool-calling parameters that some backends reject and handles cases where tool output is empty, reducing validation failures that could previously break tool-using chats mid-run. ([#10671](https://github.com/RooCodeInc/Roo-Code/pull/10671), [#10672](https://github.com/RooCodeInc/Roo-Code/pull/10672))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v3.40.0 and v3.40 release notes, the only contributor credit is "(thanks Idlebrand!)" for the tool-calling compatibility fixes. Per the updated rules, acknowledgements should include both PR author and issue reporter unless excluded by the exclusion list. For PR #10671 the author is daniel-lxs (excluded) but the issue reporter is Idlebrand (not excluded), so the thanks parenthetical should likely include only Idlebrand and not omit it entirely.

Fix it with Roo Code or mention @roomote and request a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants