-
Notifications
You must be signed in to change notification settings - Fork 176
docs: Release Notes for v3.40 #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review complete. Left a few actionable notes for rules consistency and to avoid edge cases in the hero-image discovery step.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| [Concluding sentence about impact] | ||
|
|
||
| > **📚 Documentation**: See [Feature Guide](/path/to/feature) for detailed usage instructions. | ||
| ## [Feature Name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the markdown templates under major_features/expanded_sections, the headings and paragraphs start with a leading space (for example " ##"), and there are lines that are just a single space. If copied verbatim into MDX, this can prevent headings from being recognized and introduces trailing whitespace. Recommend removing the leading/trailing spaces so templates are valid markdown as-is.
Fix it with Roo Code or mention @roomote and request a fix.
|
|
||
| <step number="1b"> | ||
| <action>Resolve hero image from discovered candidates, falling back to social-share when none exist</action> | ||
| <action>Resolve hero image from discovered candidates (no placeholder if none exist)</action> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step 1b notes say to skip hero image download when no candidates were discovered, but the script always does head -n1 and curl even if the candidates file is empty/missing. In that case the URL becomes .../main/ and can still produce a non-empty output (for example an HTML 404 page), which would incorrectly get treated as a valid hero image. Consider adding an explicit -s/empty check for $CANDIDATES_FILE (and optionally verifying HTTP status/content-type) before downloading and writing the frontmatter path.
Fix it with Roo Code or mention @roomote and request a fix.
|
|
||
| ## Tool-calling compatibility fixes | ||
|
|
||
| This release improves compatibility across providers (especially Gemini and OpenAI-compatible backends) by addressing request/response validation edge cases (thanks Idlebrand!). Roo now avoids sending tool-calling parameters that some backends reject and handles cases where tool output is empty, reducing validation failures that could previously break tool-using chats mid-run. ([#10671](https://github.com/RooCodeInc/Roo-Code/pull/10671), [#10672](https://github.com/RooCodeInc/Roo-Code/pull/10672)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v3.40.0 and v3.40 release notes, the only contributor credit is "(thanks Idlebrand!)" for the tool-calling compatibility fixes. Per the updated rules, acknowledgements should include both PR author and issue reporter unless excluded by the exclusion list. For PR #10671 the author is daniel-lxs (excluded) but the issue reporter is Idlebrand (not excluded), so the thanks parenthetical should likely include only Idlebrand and not omit it entirely.
Fix it with Roo Code or mention @roomote and request a fix.
Summary
Adds release notes for the v3.40 series (v3.40.0, v3.40.1) and updates the release notes writer configuration rules.
Changes
docs/update-notes/v3.40.0.mdxdocs/update-notes/v3.40.1.mdxdocs/update-notes/v3.40.mdxdocs/update-notes/index.mdandsidebars.tsstatic/img/v3.40.0/v3.40.0.pngImportant
Adds release notes for v3.40, updates release notes writer configuration, and includes new version in documentation index and sidebars.
v3.40.0.mdx,v3.40.1.mdx, andv3.40.mdxfor version 3.40 release notes.index.mdto include links to the new release notes.sidebars.tsto include the new version 3.40 in the navigation.1_main_workflow.xmland2_content_standards.xmlto refine image handling and contributor acknowledgments.v3.40.0.pngtostatic/img/v3.40.0/.This description was created by
for 6336290. You can customize this summary. It will automatically update as commits are pushed.