corkscrew: Fix build with gcc 4.8+ #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will require that transitioning devices have context as the last mount option, since everything after it will be ignored Change-Id: Ic5cc7f5632cc3d62459dfaaf7719d662737e1641
since the scon is now a mandatory arg, it needs to exist even if NULL Change-Id: I8ba31a7a8cf357e9b0c43cee81ab49d3eb192819
gcc 4.8 has a new warning for unused parameters - we need to override -Werror on that. Change-Id: Ia2a831a96750ae105440291c636b80382a5702fa Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
Author
|
Recent changes to camera on HTC msm8960(evita,ville,jewel) devices cause issues with gcc-4.7, -O3 optimizations, and some of the CFLAGS that are on by default in Rootbox. Moving to GCC-4.8 fixes it. Fix was tested on compile with 4.7 just to be sure nothing was broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 4.8 has a new warning for unused parameters - we need to override
-Werror on that.
Change-Id: Ia2a831a96750ae105440291c636b80382a5702fa
Signed-off-by: Bernhard Rosenkränzer Bernhard.Rosenkranzer@linaro.org