Issue #3186: Enable ReferenceDF as targets for LensDFs. #4747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current issue is solved, the reference dynamic fields are no longer prohibited from being used as targets for lens dynamic fields.
The check for reference filters took priority over the lens param entirely, which the commit changed. Also, the lens param needs to precede the check for reference filter content in case that we end up there without reference filters configured.
In case that a lens field points to a reference field, the reference search module needs to take an extra step in looking up the target of lens fields.
In case that the target of a lens field has the behavior SetsDynamicContent, a call to GetFieldState() of the respective backend is necessary to get the content.
The JS needs to be able to handle lenses on autocomplete reference fields as well as lenses to dropdown reference fields.
While at it, fixed a typo as well.
chzauleck
reviewed
Nov 21, 2025
Contributor
chzauleck
left a comment
chzauleck
left a comment
There was a problem hiding this comment.
Regarding the changes in Core.Ajax.js:
I would suggest adding a comment when using a regular expression that gives an idea about what we're looking for there in human readable form. (no expectation to go into detail, just makes reading the code easier to have a rough idea imo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3186
replaces #3187