Issue #4776 double escaped html customer body #5011
+97
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1: Customer Body is prepared inside AgentTicketCompose, let
TemplateGenerator know if there is already HTML present
2: Previous handling of double escaped HTML returned by
_Replace caused issues for properly, singly escaped
fields like OTOBO_CUSTOMER_SUBJECT
3: My current assumption is that when TemplateGenerator
receives IDs (TemplateID, TicketID, etc.) they are
handled properly
TODO: AgentTicketEmailOutbound and AgentTicketForward should
both in theory support the same templates as
AgentTicketCompose, yet they don't run into double html
escaping issues simply because they don't prepare the
customer body and therefore e.g. don't display inline
images at all
Fixed TemplateGenerator->_Replace to work when receiving $Data{Body}
populated by LayoutObject->ArticleQuote. Non-line-limited bodies are
for now limited to 2500 lines, since this is how OTOBO_CUSTOMER_COMMENT
was previously handled.
TODO: AgentTicketForward is the only one of the three modules currently
passing body from ArticleQuote as expected by TemplateGenerator, but
also only temporary right now.
Look at AgentTicket-Compose/Forward/EmailOutbound and standardize how
and where body is passed and how it is included after signature.
TODO: Check other dependents on specifically TemplateGenerator->_Replace
AgentTicketCompose/-Forward/-MailOutbound now all call ArticleQuote first before passing Data to TemplateGenerator->Template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4776