Open
Conversation
Unsure why so many style issues/inconsistencies when it is obvious there are style opinions, as provided by the .rubocop.yml file.
Member
|
yo! sorry for the slow reply in this. Just getting back from some trips and stuff... I like having a more consistent style, for sure. Some of your changes I agree, with, some I'm not sure of. Are you basing this off of a particular style guide that I can link to? I'll give this a full look soon... |
Contributor
Author
|
Good question of where I got the styles. Not surprisingly, I believe I got them from your very own established styles that you have as authoritative and accepted as of Dec 13, 2014. See your style changes as approved here, and then see the style guide that Rubocop adopts from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure why so many style issues/inconsistencies when it is obvious there
are style opinions, as provided by the .rubocop.yml file.