Add support for multiple properties files#2689
Conversation
…ithub.com/RuminantFarmSystems/RuFaS into add-support-for-multiple-properties-files
|
Current Coverage: 99% Mypy errors on add-support-for-multiple-properties-files branch: 1720 |
|
🚨 Unauthorized changes detected in protected files. Please remove these changes if they are not intended. |
ew3361zh
left a comment
ew3361zh
left a comment
There was a problem hiding this comment.
LGTM! No issues to report in my testing.
Co-authored-by: Niko <70217952+ew3361zh@users.noreply.github.com>
|
Current Coverage: 99% Mypy errors on add-support-for-multiple-properties-files branch: 1720 |
|
🚨 Unauthorized changes detected in protected files. Please remove these changes if they are not intended. |
|
Current Coverage: 99% Mypy errors on add-support-for-multiple-properties-files branch: 1720 |
|
🚨 Unauthorized changes detected in protected files. Please remove these changes if they are not intended. |
|
Current Coverage: 99% Mypy errors on add-support-for-multiple-properties-files branch: 1685 |
|
🚨 Unauthorized changes detected in protected files. Please remove these changes if they are not intended. |
JoeWaddell
left a comment
JoeWaddell
left a comment
There was a problem hiding this comment.
Looks good: the changes make sense, and I couldn't manage to break it. Updated info in the onboarding docs helpful as well. Nice work!
|
Current Coverage: 99% Mypy errors on add-support-for-multiple-properties-files branch: 1685 |
|
🚨 Unauthorized changes detected in protected files. Please remove these changes if they are not intended. |
3 participants
Context
Issue(s) closed by this pull request: closes # N/A
What
Makes it possible to break the metadata properties into multiple files instead one gigantic file.
Why
Helps with the organization and handling of the metadata properties.
How
Changes the path to properties in the metadata to a list. Modifies input manager and data validator accordingly.
Test plan
python main.pyInput Changes
Changes the path to properties in the metadata to a list.
Output Changes
Filter