Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the full CI/CD pipeline for the Runtime Node project via two GitHub Actions workflows. The first workflow automates Dockerfile linting and multi-platform image build and integrity testing on every pull request targeting
mainordevelop. The second workflow automates the build and publishing of the final multi-architecture Docker image to both Docker Hub and the GitHub Container Registry on everyv*tag push.Together, these two workflows establish the complete automated quality gate and release pipeline for the project, ensuring that every proposed change is validated across
linux/amd64andlinux/arm64before being merged, and that every tagged release is published consistently and reproducibly to both registries.Files Changed
Added:
.github/workflows/deployment.ymlpr-tests.ymlModified:
Deleted:
Key Changes
deployment.yml— a workflow triggered onv*tag pushes that builds and pushes the multi-platform image (linux/amd64,linux/arm64) to both Docker Hub (runtimenode/runtime-node) and GHCR (ghcr.io/Runtimes-Node/runtime-node) with provenance and SBOM attestations enabled.pr-tests.yml— a workflow triggered on pull requests targetingmainordevelopthat runs in two sequential jobs:lint(Hadolint Dockerfile linting with awarningfailure threshold) andbuild-and-test(multi-platform matrix build and smoke/integrity testing).node --version), a no-shell distroless guarantee test, a no-package-manager distroless guarantee test, and aNODE_ENV=productionenvironment validation test.concurrencygroups on both workflows to prevent duplicate runs —release-${{ github.ref_name }}for deployment andpr-tests-${{ github.event.pull_request.number }}for PR tests, both withcancel-in-progress: true.type=ghacaching in both workflows with platform-scoped cache keys in the PR testing workflow to speed up multi-platform builds.docker/metadata-actionto auto-generate image tags, including thev*tag and alatestalias.DOCKERHUB_USERNAME,DOCKERHUB_TOKEN,GITHUB_TOKEN).actions/checkout@v4,docker/setup-qemu-action@v3, etc.) for reproducibility.