adds link on each row to github page and remove entire row clickable feature #1959
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanugarte
reviewed
Dec 25, 2025
src/Pages/Projects/Projects.js
Outdated
Comment on lines
208
to
214
| <a | ||
| href={link} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| style={{ textDecoration: 'underline' }} | ||
| > {link} | ||
| </a> |
Collaborator
There was a problem hiding this comment.
how does this look in the mobile ui of the website? should we do an icon instead?
https://developer.chrome.com/docs/devtools/device-mode#viewport
Author
There was a problem hiding this comment.
It looks similar to desktop, so I believe it looks fine. But, I can shorten the link to say "Github" or use an icon instead if needed.
Author
Shortened Link in mobile view |
evanugarte
reviewed
Dec 27, 2025
Comment on lines
+206
to
+212
| <br /> | ||
| <br /> | ||
| <a | ||
| href={link} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className={'underline'} |
Collaborator
There was a problem hiding this comment.
instead of br wanna try pt-4 in the classname
https://tailwindcss.com/docs/padding#adding-padding-to-one-side
i approve either way
evanugarte
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1955