Merged
Conversation
AfonsoMota-132
approved these changes
Jan 20, 2026
Contributor
AfonsoMota-132
left a comment
AfonsoMota-132
left a comment
There was a problem hiding this comment.
the code changes seem clear and understandable, and the test example passed as it should :3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This PR resolves a small issue in the RX handler on the STM32. The main change is removing the dependency on a function that was supposed to be called automatically (but was not being triggered) and instead explicitly calling the RX handler inside the RX thread.
Related issues
#106
Type of change
Testing instructions
Replicate the end-to-end communication between the Raspberry Pi (or alternatively use candump functionality) and observe the debug messages that indicate when new CAN messages arrive.