Removed comments + added line highlight at position of keyword#268
Open
alexcojocaru2002 wants to merge 2 commits intoSERG-Delft:mainfrom
Open
Removed comments + added line highlight at position of keyword#268alexcojocaru2002 wants to merge 2 commits intoSERG-Delft:mainfrom
alexcojocaru2002 wants to merge 2 commits intoSERG-Delft:mainfrom
Conversation
Contributor
Author
|
@martinmladenov How should I rename the class ? Also should I write a separate test for removeComments method ? |
andy/src/main/java/nl/tudelft/cse1110/andy/execution/step/SourceCodeSecurityCheckStep.java
Show resolved
Hide resolved
| return false; | ||
| String[] lines = code.split("\\n"); | ||
| // Split lines and search every line for keyword | ||
| for (int lineNumber = 0; lineNumber < lines.length; lineNumber++) |
Contributor
There was a problem hiding this comment.
Can we have a test showing what this should do? :)
Collaborator
Good question, I haven't thought about that. Maybe something like "SourceCodeCheckStep" would be suitable (but this could be misleading as people might think it has to do with code checks). If you think of anything more suitable, feel free to use that instead. @mauricioaniche Do you have any ideas? |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213
The aim of this Pull Request is to improve the SourceCodeSecurityCheckStep class.