Conversation
1. add read_exact option
There was a problem hiding this comment.
Pull request overview
This PR bumps the version to v0.1.1 and introduces a new read_exact option that allows users to control whether reads must fill the entire buffer or can be partial.
Changes:
- Added
read_exactboolean field toOptionsstruct with a builder methodwith_read_exact() - Implemented
read_exactlogic in both fallback read path (usingread_exact_at) and device read path (with validation) - Updated version numbers in Cargo.toml and Cargo.lock from 0.1.0 to 0.1.1
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Cargo.toml | Version bump from 0.1.0 to 0.1.1 |
| Cargo.lock | Version bump from 0.1.0 to 0.1.1 |
| src/options.rs | Added read_exact field with documentation, default value, and builder method |
| src/reader.rs | Implemented read_exact logic in both fallback and device read paths with appropriate error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_exactoption