Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a dry_run option to the blkreader library and CLI tool, allowing users to validate extent mapping and file structure without performing actual I/O operations. The version is bumped from v0.1.1 to v0.1.2.
Changes:
- Added
dry_runfield to Options struct with corresponding builder method - Implemented dry_run mode in reader logic to skip actual I/O operations
- Added
--dry-runCLI flag to the blkreader binary - Updated documentation to describe the new feature
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumped version from 0.1.1 to 0.1.2 |
| Cargo.lock | Updated version lock to 0.1.2 |
| src/options.rs | Added dry_run field, default value, and builder method with documentation |
| src/reader.rs | Implemented dry_run logic in fallback_read and DeviceHandle::read_at methods, added test for options builder |
| src/bin/blkreader.rs | Added --dry-run CLI argument and wired it to Options |
| README.md | Documented the --dry-run option and its use cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1. add `dry_run` option
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dry_runoption