Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 901 902 +1
=========================================
+ Hits 901 902 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR bumps the version from 0.1.15 to 0.1.16 and includes important improvements to the sharding architecture and documentation. The key change is refactoring ShardsMap to use an instance-level RandomState hasher instead of creating a new FixedState on each shard lookup, which improves hash consistency. Documentation has been significantly enhanced with new caveats about lock poisoning behavior and performance characteristics.
- Refactored
ShardsMapto use an instance-levelRandomStatehasher for consistent key-to-shard mapping - Added comprehensive documentation about lock poisoning, performance considerations, and usage patterns
- Enhanced README with expanded feature descriptions, caveats, and improved code examples
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Version bumped from 0.1.15 to 0.1.16 |
| src/shards_map.rs | Refactored to store RandomState hasher as instance field and use it in shard() method instead of creating FixedState on each call |
| src/lockmap.rs | Added documentation for inc_ref() method explaining reference count limits, and added performance note to get() method about clone behavior |
| src/lib.rs | Added feature bullet about no lock poisoning on panic |
| README.md | Significantly expanded with new sections on features, caveats (lock poisoning, get() performance), and improved usage examples with more detailed comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.