Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 6 6
Lines 676 898 +222
==========================================
+ Hits 676 898 +222 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new MassMapMerger feature to efficiently merge multiple massmap files without full deserialization. The merger enables combining disjoint bucket ranges from multiple massmaps into a single consolidated file.
Key changes:
- Introduced
MassMapMergerto merge multiple massmap files - Replaced
empty_bucketswithoccupied_bucket_countand addedoccupied_bucket_rangeto track non-empty bucket distribution - Made
bucket_metasandreaderfields accessible within the crate to support merging
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/meta.rs | Updated MassMapMeta to track occupied buckets with count and range instead of empty bucket count |
| src/massmap.rs | Changed visibility of bucket_metas and reader from private to pub(crate) to enable merge operations |
| src/lib.rs | Exported MassMapMerger as a public API |
| src/builder.rs | Added MassMapMerger implementation with merge logic, updated builder to track occupied bucket ranges, and added comprehensive test coverage |
| examples/massmap.rs | Added CLI merge command with argument handling |
| README.md | Updated documentation examples to reflect the new occupied_bucket_count field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.