feat: add nav fixed and link self #233
Open
+35
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Descreve melhor esse PR, coloca exemplos do problema e do resultado da sua implementação, por que só código sem contexto é mais difícil de revisar. |
ipetinate
reviewed
May 17, 2024
| <Sheet> | ||
| <SheetTrigger> | ||
| <Menu color="white" className="ml-2 mr-2" /> | ||
| <Menu color="white" className="ml-2 mr-2 " /> |
There was a problem hiding this comment.
Tem um espaço sobrando no atributo de classe
Suggested change
| <Menu color="white" className="ml-2 mr-2 " /> | |
| <Menu color="white" className="ml-2 mr-2" /> |
ipetinate
reviewed
May 17, 2024
| <Menu color="white" className="ml-2 mr-2 " /> | ||
| </SheetTrigger> | ||
| <SheetContent side="left" className="pt-[96px] flex flex-col"> | ||
| <SheetContent side="left" className="pt-[96px] flex flex-col "> |
There was a problem hiding this comment.
Suggested change
| <SheetContent side="left" className="pt-[96px] flex flex-col "> | |
| <SheetContent side="left" className="pt-[96px] flex flex-col"> |
ipetinate
reviewed
May 17, 2024
| icon={<CircleHelp className="w-4 h-4" />} | ||
| /> | ||
| <BurguerMenuItem | ||
| targetLink='' |
There was a problem hiding this comment.
Não tem como omitir a prop já que não tem valor?
Altera a interface dela no componente para opcional, assim não precisa passar string vazia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.