Replacing print statements with logging statements#1
Open
sdfgeoff wants to merge 1 commit intoSPOCKnots:masterfrom
sdfgeoff:master
Open
Replacing print statements with logging statements#1sdfgeoff wants to merge 1 commit intoSPOCKnots:masterfrom sdfgeoff:master
sdfgeoff wants to merge 1 commit intoSPOCKnots:masterfrom
sdfgeoff:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to use the pyknotid library as part of a larger system, the continous printing of debug information is a little annoying. Particularly because python has the logging module as a standard library (the vprint functions which are scattered all through the code act as a miniature logging priority system).
Ideally all calls to:
should be replaced with calls to logging.info (one of the lowest priority messages). Users of the library can then configure the logging module to either display the information or to not.
I haven't replaced all the print statements here, only the ones that influence my intended use. More may change in the future if I start using other parts of the library. If someone is bored for several hours, the can go through the whole library.....