Skip to content

Python 3+ code plus code cleanup plus github workflows added #15

Open
sashakolpakov wants to merge 20 commits intoSPOCKnots:masterfrom
sashakolpakov:master
Open

Python 3+ code plus code cleanup plus github workflows added #15
sashakolpakov wants to merge 20 commits intoSPOCKnots:masterfrom
sashakolpakov:master

Conversation

@sashakolpakov
Copy link

No description provided.

@sashakolpakov
Copy link
Author

@inclement Lots of rewrites, please check if this is acceptable. If not, I will keep my own fork.

@inclement
Copy link
Collaborator

Thanks very much, this looks all very good to me. I've left a couple of questions, including that I think ideally the doc build artifacts should be omitted from the repo, but will be happy to merge in general

@@ -0,0 +1,41 @@
name: Tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this gets the test build working again? But it looks like we don't have a link to the build passing status at the top of the readme any more, could we add that convenience?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed my version of the github pages deployment for the docs, but then I need help from @inclement with ReadTheDocs, as I never deployed via it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise is shows "docs:failing". @inclement please correct me if I'm wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants