Open
Conversation
esthel7
approved these changes
Apr 4, 2024
Member
esthel7
left a comment
esthel7
left a comment
There was a problem hiding this comment.
너무 늦게 봤슴다ㅠㅠ 죄송죄송💦
찬우님의 칼같은 prettier 나 적응안돼ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 너무 굿굿👍
실력 어ㅓㅓㅓㅓㅓㅓㅓㅁ청 늘은것같음.. 얼른 공부해서 따라가겟슴다🔥
Comment on lines
+25
to
+36
| const FAQS = [ | ||
| { | ||
| question: 'What exactly is PlusAlpha?', | ||
| answer: | ||
| 'PlusAlpha is a specialized online platform designed to cater to the needs of students studying AP Calculus in the USA. It provides a comprehensive array of math problems, resources, and tools specifically tailored to enhance learning and preparation for the AP Calculus exam.', | ||
| }, | ||
| { | ||
| question: 'How can PlusAlpha benefit me as an AP Calculus student?', | ||
| answer: | ||
| 'PlusAlpha offers a dynamic learning environment where students can access a wide range of practice problems, quizzes, and instructional materials aligned with the AP Calculus curriculum. By utilizing our platform, students can strengthen their understanding of calculus concepts, improve problem-solving skills, and ultimately boost their performance on the AP exam.', | ||
| }, | ||
| { |
Comment on lines
+7
to
+21
| const buttonVariants = cva( | ||
| 'inline-flex items-center justify-center whitespace-nowrap rounded-md text-sm font-medium ring-offset-background transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50', | ||
| { | ||
| variants: { | ||
| variant: { | ||
| default: 'bg-primary text-primary-foreground hover:bg-primary/90', | ||
| destructive: | ||
| 'bg-destructive text-destructive-foreground hover:bg-destructive/90', | ||
| outline: | ||
| 'border border-input bg-background hover:bg-accent hover:text-accent-foreground', | ||
| secondary: | ||
| 'bg-secondary text-secondary-foreground hover:bg-secondary/80', | ||
| ghost: 'hover:bg-accent hover:text-accent-foreground', | ||
| link: 'text-primary underline-offset-4 hover:underline', | ||
| }, |
Member
There was a problem hiding this comment.
진짜 대박.. 찬우님 어나더레벨이다ㅋㅋㅋㅋㅋ 얼른 익히겟슴다🔥
Member
Author
There was a problem hiding this comment.
components/ui 하위 파일들은 전부다 설치한 라이브러리 파일들이 담기는거라
내가 직접 설정해준 파일들은 아니야
esthel7
reviewed
Apr 4, 2024
Comment on lines
+1
to
+7
| import AccordionSection from '@/app/(tmp)/_components/sections/AccordionSection'; | ||
| import ButtonSection from '@/app/(tmp)/_components/sections/ButtonSection'; | ||
| import CardSection from '@/app/(tmp)/_components/sections/CardSection'; | ||
| import InputSection from '@/app/(tmp)/_components/sections/InputSection'; | ||
| import LabelSection from '@/app/(tmp)/_components/sections/LabelSection'; | ||
| import RadioGroupSection from '@/app/(tmp)/_components/sections/RadioGroupSection'; | ||
| import DialogSection from '@/app/(tmp)/_components/sections/DialogSection'; |
Member
There was a problem hiding this comment.
여기 index.tsx 써서 하나로 묶을까요? 이게 더 가독성이 나은가? 잘모르겟넹~
나중에 alias 추가해서 경로 좀 더 단순화시킬게요!!👍
Member
Author
There was a problem hiding this comment.
이거는 나중에 UI 어떻게 사용하는지 참고하려고 임시로 만들어둔 섹션들 (tmp) 라우팅은 나중에 전부 지울듯
Member
Author
|
|
kcwww
commented
Apr 5, 2024
Member
Author
There was a problem hiding this comment.
이 useForm을 잘쓰면 state 안쓰고 에러 메세지 까지 관리가 가능해서 편해
esthel7
approved these changes
Apr 5, 2024
Contributor
|
이 PR은 문화유산으로 남겨놔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
react-hook-form과zod를 사용해 여러 상태를 관리하지 않아도 에러메시지나 인풋을 쉽게 관리 가능ui page 에서 해당 컴포넌트들 확인 가능 (후에 더 많은 UI 추가 예정)