board: stm32mp2: fix fwu_mdata node updating #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing the SD card boot with the eMMC one, the DTS differs as follows: - fwu-mdata-store = <0x00000085>; + fwu-mdata-store = "/soc@0/bus@42080000/mmc@48230000"; In both cases, the U-Boot DTS loaded by tf-a-stm32mp at address 0x84400000 was obtained with the following commands: STM32MP> fdt addr 0x84400000 Working FDT set to 84400000 STM32MP> fdt print As shown in the diff, the working case (SD card) uses a numeric value, i.e. the phandle of the sdmmc1 node, while the eMMC case uses a path. This patch updates the fwu-mdata-store property to use the phandle instead of the path. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the SD card boot with the eMMC one, the DTS differs as follows:
In both cases, the U-Boot DTS loaded by tf-a-stm32mp at address 0x84400000 was obtained with the following commands:
STM32MP> fdt addr 0x84400000
Working FDT set to 84400000
STM32MP> fdt print
As shown in the diff, the working case (SD card) uses a numeric value, i.e. the phandle of the sdmmc1 node, while the eMMC case uses a path. This patch updates the fwu-mdata-store property to use the phandle instead of the path.
Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please
see https://u-boot.readthedocs.io/en/latest/develop/sending_patches.html
The only exception to this is in order to trigger a CI loop on Azure prior
to posting of patches.