Fix dlopen directory lookup behavior #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `dlopen` and `dlmopen` were interposed, it changed the search paths because the caller were now `libpulp.so.0` rather than the original application. This interposition were done for reasons of ensuring that we knew when an application has called `dlopen` by locking a lock in libpulp, but its not necessary anymore since we hijack the `dl_load_lock` from glibc. Signed-off-by: Giuliano Belinassi <gbelinassi@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
dlopenanddlmopenwere interposed, it changed the search paths because the caller were nowlibpulp.so.0rather than the original application. This interposition were done for reasons of ensuring that we knew when an application has calleddlopenby locking a lock in libpulp, but its not necessary anymore since we hijack thedl_load_lockfrom glibc.