Open
Conversation
kaimmej
requested changes
Jun 14, 2023
kaimmej
left a comment
kaimmej
left a comment
There was a problem hiding this comment.
I like what you have here and I like that you used StringTokenizer.
Two of your methods in StringManipulation are commented out and currently set to return null.
I added comments and suggestions throughout.
adrianturcan
commented
Jun 15, 2023
Author
adrianturcan
left a comment
adrianturcan
left a comment
There was a problem hiding this comment.
I edited my files so now should be all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.