You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Wesley,
In my opinion, Each test is initially set to fail with the fail("Not yet implemented"); line. This line should be removed as tests are implemented. The names of the tests are not descriptive enough to indicate what they are testing. A test name should give an indication of what functionality or aspect of functionality it is testing. You've done a good job of testing for exceptions. In particular, the tests testRemoveNthCharacter5(), testRemoveNthCharacter6(), testRemoveNthCharacter7(), testGeSubStrings3(), testGeSubStrings4(), testGeSubStrings5(), testGeSubStrings6(), testRestoreString4(), and testRestoreString5() are good examples of how to test for exception conditions. Repeated Tests: The tests testGeSubStrings5() and testGeSubStrings6() appear to be duplicates, as do testRestoreString4() and testRestoreString5(). Each test should be unique and test a different aspect of functionality. I appreciate the thoroughness of the testing. Many different cases and potential issues are checked for, which is excellent, but some of the tests should match the class implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.