Added new versions of StringManipulation .java files#6
Added new versions of StringManipulation .java files#6AaronBird759 wants to merge 1 commit intomainfrom
Conversation
| @Test | ||
| public void testCount4() { | ||
| fail("Not yet implemented"); | ||
| manipulatedstring.setString("This a string that can't fail just because \"can't\" is in the string"); |
There was a problem hiding this comment.
This test seems redundant with Test case #1. Can it be replaced with testing extra whitespace (EX: " abc") and the one where string has more than 1 whitespace between words (EX: "abc def")?
| assertEquals(sStings[1], "string"); | ||
| } | ||
|
|
||
| // test to make sure that it can scale to more substrings |
There was a problem hiding this comment.
Recommend modifying this test case so that it calls getSubStrings(1,15) (i.e. get all the words in a string).
| } | ||
|
|
||
| // tests thats endWord cannot be <= 0 and should throw a | ||
| // IllegalArgumentException |
There was a problem hiding this comment.
Modify testGeSubStrings4 so that startWord is an integer greater than 0. This ensures that the exception is caused by the endWord <= 0, not because startWord is <= 0.
| @@ -1,33 +1,94 @@ | |||
| public class StringManipulation implements StringManipulationInterface { | |||
|
|
|||
There was a problem hiding this comment.
Modify or add additional test cases in StringManipulationTest.java. If new test cases failed, modify this file so that it passes the said test cases.
| @@ -2,7 +2,6 @@ | |||
| import org.junit.jupiter.api.BeforeEach; | |||
| import org.junit.jupiter.api.Test; | |||
|
|
|||
There was a problem hiding this comment.
Recommend adding some test cases for setString() and getString() for sake of sanity. Be sure to add cases when this.string is null and when you try to set this.string to null as well as when string is empty.
| array = new int[] { 0, 1, 2, 3, 4, 5 }; | ||
| assertThrows(IllegalArgumentException.class, () -> manipulatedstring.restoreString(array)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Add another test case for restoreString() for case when string contains more than 1 word, such as "Hello world".
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
|
|
There was a problem hiding this comment.
Also add cases in each method when string is null or empty.
| manipulatedstring.setString("This Test should throw IndexOutOfBoundsException for endWord > string length"); | ||
| assertThrows(IndexOutOfBoundsException.class, () -> manipulatedstring.getSubStrings(1, 100)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Add test case for getSubStrings() when startWord = endWord.
Emc2Ikeda
left a comment
Emc2Ikeda
left a comment
There was a problem hiding this comment.
Watch out for corner cases not described in the interface. For example, how should methods act when this.string is null or empty? I noted the ones I found in inline comments for StringManipulationTest.java. Then, re-test the StringManipulation class. If the new test cases fail, modify StringManipulation so that it passes all the new tests.
2 participants
No description provided.