will_eand added Junit implementation by will-eand · Pull Request #7 · SWE-CS410/5540-Spring23CodeReviewActivity

will-eand · 2023-06-14T18:21:07Z

this is a pull request?

src/main/java/StringManipulation.java

will-eand · 2023-06-18T19:28:11Z

I re-pushed after reviewing the changes FLSGawsi. I have a new commit to document these fixes for my Unit Assignment

FLSGawsl · 2023-06-20T00:08:10Z

src/main/java/StringManipulation.java

    @Override
    public String getString() {
-        return null;
+        return message;


Naming: The variable names are meaningful and descriptive, making the code more readable.

FLSGawsl · 2023-06-20T00:09:38Z

src/main/java/StringManipulation.java

+        for (int i = 0; i < array.size(); i++) {
+            a = a + array.get(i);
+        }
+        return a;


The removeNthCharacter method correctly removes every nth character from the string while maintaining spacing as specified.

FLSGawsl · 2023-06-20T00:10:28Z

src/main/java/StringManipulation.java

+        for (int i = startWord - 1; i < endWord; i++) {
+            finalStringArray[count++] = tempStringArray[i];
+        }
+        return finalStringArray;


There's an unnecessary conversion to an intermediate ArrayList that can be avoided by using an array directly.

FLSGawsl · 2023-06-20T00:11:20Z

src/main/java/StringManipulation.java

+        }
+        return finalString;
+    }
+}


Using a HashMap is a good approach to storing the character values associated with indices.

FLSGawsl

Overall, the code implements the required functionality.

will_eand added Junit implementation

3fca2e3

sarafarag requested a review from FLSGawsl June 14, 2023 18:26