updated the skeleton project with my complete project. #20
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,125 @@ | ||
| public class StringManipulation implements StringManipulationInterface { | ||
| private String str; | ||
|
|
||
| @Override | ||
| public String getString() { | ||
| return this.str; | ||
| } | ||
|
|
||
| @Override | ||
| public void setString(String string) { | ||
| this.str = string; | ||
| } | ||
|
|
||
| @Override | ||
| public int count() { | ||
| if (str == null || str.isEmpty()) { | ||
| return 0; | ||
| } | ||
|
|
||
| String[] splitStr = str.split("\\s+"); | ||
| return splitStr.length; | ||
| /* | ||
| * int wordCount = 0; | ||
| boolean whitespace = false; | ||
|
|
||
| // Iterate through each character in the string | ||
| for (int i = 0; i < str.length(); i++) { | ||
| char c = str.charAt(i); | ||
|
|
||
| // Check if the character is a whitespace | ||
| if (Character.isWhitespace(c)) { | ||
| whitespace = true; | ||
|
|
||
| // Check if the character is a letter or digit | ||
| if (Character.isLetterOrDigit(str.charAt(i+1))) { | ||
| // If we are not inside a word, increment the word count | ||
| if (whitespace) { | ||
| wordCount++; | ||
| whitespace = false; | ||
| } | ||
| }*/ | ||
| } | ||
|
|
||
| @Override | ||
| public String removeNthCharacter(int n, boolean maintainSpacing) { | ||
| if (n <= 0) { | ||
| throw new IllegalArgumentException("'n' must be greater than zero."); | ||
| } | ||
|
|
||
| if (n > str.length()) { | ||
| throw new IndexOutOfBoundsException("'n' is greater than the string length."); | ||
| } | ||
|
|
||
| String result = new String(); | ||
| result = result.concat(str.charAt(0) + ""); | ||
|
There was a problem hiding this comment. This portion of the for loop in the removeNthCharacter() method seems to have some redundant code. Is there an advantage to starting your for loop at index = 1? |
||
| for (int i = 1; i < str.length(); i++) { | ||
| if((i+1) % n != 0) { | ||
| result = result.concat(str.charAt(i) + ""); | ||
|
There was a problem hiding this comment. This is personal preference but I like using += when concatenating strings together. Personally I think that nesting methods inside one another makes code harder to read. |
||
| } | ||
| else { | ||
| if (maintainSpacing) { | ||
| result = result.concat(" "); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public String[] getSubStrings(int startWord, int endWord) { | ||
| // Check for invalid arguments | ||
| if (startWord <= 0 || endWord <= 0 || startWord > endWord) { | ||
| throw new IllegalArgumentException("Invalid startWord or endWord"); | ||
| } | ||
|
|
||
| // Split the sentence into words | ||
| String[] words = str.split("\\s+"); | ||
|
|
||
| // Check if the sentence has enough words | ||
| if (endWord > words.length) { | ||
| throw new IndexOutOfBoundsException("The String has less than " + endWord + " words"); | ||
| } | ||
|
|
||
| // Calculate the number of words to put in the array | ||
| int wordCount = endWord - startWord + 1; | ||
|
|
||
| // Create a new array to store the extracted words | ||
| String[] subStrArr = new String[wordCount]; | ||
|
|
||
| // Extract the words from the specified positions | ||
| for (int i = 0; i < wordCount; i++) { | ||
| subStrArr[i] = words[startWord - 1 + i]; | ||
| } | ||
|
|
||
| return subStrArr; | ||
| } | ||
|
|
||
| @Override | ||
| public String restoreString(int[] indices) { | ||
| //throws IllegalArgumentException if not s.length == indices.length == n | ||
| // throws IndexOutOfBoundsException if indices[i]< 0 or indices[i]> string length | ||
| if(str.length() != indices.length) { | ||
| throw new IllegalArgumentException("The indices array must be the same length as the string."); | ||
| } | ||
| char[] temp = str.toCharArray(); | ||
| char[] shuffled = new char[str.length()]; | ||
| String output = new String(); | ||
| for(int i = 0; i < str.length(); i++) { | ||
| if(i < indices.length) { | ||
| int pos = indices[i]; | ||
| if(pos < 0 || pos > str.length()) { | ||
| throw new IndexOutOfBoundsException("All values in the indices array must correspond to valid indexes in the string."); | ||
| } | ||
| shuffled[pos] = temp[i]; | ||
| } | ||
| else{ | ||
| shuffled[i] = temp[i]; | ||
| } | ||
| } | ||
| output = String.valueOf(shuffled); | ||
| return output; | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how you used the split method with regex to get the appropriate count of words. I will definitely be implementing this into my own code. Thank you