Open
Conversation
ulyfm
requested changes
Jun 18, 2023
ulyfm
left a comment
ulyfm
left a comment
There was a problem hiding this comment.
Overall I agree with pretty much everything. I think most of my concerns stem from the specification being slightly vague:
- How does the spec want us to define a 'word'. A regex word, like you did? Or an English word, which might have additional punctuation like apostrophes?
- Is the string allowed to be null? Or should it always be initialized to an empty string?
- Can there be more than two substrings returned by the substrings method?
Once we figure out these issues, it should be good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.