Conversation
|
Code is good, with tons of functions that I wish I had done in my code, as it is more understandable than my code. A minor issue is that comment is a bit too vague. It says what codes do but not with the context of why it does. A quick explanation of code would be good. I have the same issue with comments in my own code |
| Otherwise, get the number of words in string, which are | ||
| separated by one or more whitespace characters. | ||
| */ | ||
| return string.split("[\\s\\r\\t\\n]+").length; |
There was a problem hiding this comment.
you could for this just do String[] words = string.split("\s+"); it less characters and it does job of the rest of \r\t\n. here the definition https://learn.microsoft.com/en-us/dotnet/standard/base-types/character-classes-in-regular-expressions#whitespace-character-s
| public String[] getSubStrings(int startWord, int endWord){ | ||
| //check null string | ||
| if(this.string == null) return null; | ||
| //check startWord <= 0 | ||
| if(startWord <= 0) throw new IllegalArgumentException("startWord must be greater than zero"); | ||
| //check endWord <= 0 | ||
| if(endWord <= 0) throw new IllegalArgumentException("endWord must be greater than zero"); | ||
| //check startWord > endWord | ||
| if(startWord > endWord) throw new IllegalArgumentException("startWord cannot be larger than endWord"); | ||
| //check string.count() < endWord | ||
| if(this.count() < endWord) throw new IndexOutOfBoundsException("endWord cannot be larger than the total word count"); |
There was a problem hiding this comment.
use to blank likes makes it easier to read the code also could combine the exception with or statements like this if (startWord <= 0 || endWord <= 0 || startWord > endWord) {} you could decrease the number of lines used
| //check null string | ||
| if(this.string == null) return null; | ||
| //check unequal lengths | ||
| if(this.string.length() != indices.length) throw new IllegalArgumentException("String length must match array length"); | ||
| //check valid indices | ||
| for(int i = 0; i < indices.length; i++) { | ||
| if(indices[i] < 0 || indices[i] >= this.string.length()) throw new IndexOutOfBoundsException("Invalid array index"); | ||
| } | ||
| //average case | ||
| StringBuilder b = new StringBuilder(); | ||
| for(int i = 0; i < indices.length; i++) { | ||
| b.append(this.string.charAt(indices[i])); | ||
| } | ||
| return b.toString(); |
There was a problem hiding this comment.
The minor issue about the comment you can expand to explain what is going on with context because comments are redundant with the code it is something I, too, struggle with in my code, the code looks good. i did it slightly differently where can put in IndexOutOfBoundsException in the for loop so it saves space.
| public int count() { | ||
| return 0; | ||
| //If string is null or blank, return 0. | ||
| if(this.string == null || this.string.isBlank()) return 0; |
There was a problem hiding this comment.
This is great i should have done this in my code it fairly simple and works
| if(n == 1 && !maintainSpacing) return ""; | ||
| if(n == 1 && maintainSpacing) return this.string.replaceAll(".", " "); |
There was a problem hiding this comment.
you could make this as an inbulit feature of the for loop to save space and handle edge case
| assertEquals("I' b tt r ut s0 e 16 ts in th s tr n6 r gh ?", manipulatedstring.removeNthCharacter(3, true)); | ||
| } | ||
|
|
||
| //Throws IndexOutOfBoundsException when n larger than string length |
There was a problem hiding this comment.
testing looks good but i would add for exception test for when it true just to double check if it works
| manipulatedstring.setString("12345 6789"); | ||
| String result = manipulatedstring.removeNthCharacter(1, true); | ||
| int length = result.length(); | ||
| assertEquals(10, length); |
There was a problem hiding this comment.
did not think about doing this test in my own code looks good
|
Thanks for the feedback. I went back and added spacing between my comments and removed the redundancies from my regexes. |
2 participants
No description provided.