Conversation
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import org.junit.*; |
There was a problem hiding this comment.
"package org.junit does not exist" this might be causing the error for "cannot find symbol"
There was a problem hiding this comment.
I added this to your StringManipulationTest. java to see if I could fix the problem and it seem too.
import static org.junit.jupiter.api.Assertions.*;
Causes the test cases to pass.
There was a problem hiding this comment.
Once I got it to work on my end and passing the test cases. Here's a screenshot on what I got through the verify with Maven.
There was a problem hiding this comment.
Thanks for reviewing. I'll make the proposed change.
src/test/java/TestRunner.java
Outdated
| @@ -0,0 +1,13 @@ | |||
| import org.junit.runner.*; | |||
There was a problem hiding this comment.
This whole file is failing, maybe just condense it and add it to the file StringManipulationTest.java
There was a problem hiding this comment.
When I got the other stuff to work and ran your TestRunner.java all it printed was "true".
There was a problem hiding this comment.
Probably don't need this file then.
There was a problem hiding this comment.
I'll remove the file. Thanks for reviewing.
|
|
||
| @Test | ||
| public void testRestoreString1() | ||
| { |
There was a problem hiding this comment.
Is this suppose to be empty? I believe it should have a test case in it
There was a problem hiding this comment.
It is not empty - there were just no changes made.
| public String removeNthCharacter(int n, boolean maintainSpacing) { | ||
| return null; | ||
| if(n <= 0){ | ||
| throw new IllegalArgumentException("n must be greater than or equal to 0"); |
There was a problem hiding this comment.
Maybe give a message on my it throws and error.
There was a problem hiding this comment.
I just realized that it does have a message in it.
| public int count() { | ||
| return 0; | ||
| int tally = 0; | ||
| if(myString == null || myString.length() == 0){ |
There was a problem hiding this comment.
I feel like this can be shorter for counting.
…r whitepsaces in the #7 test case for restoreString.
|
Also you need test cases for throwing the exceptions for each one in StringManipulation.java. Had the same issue in my code once I did that it passed the travis build. |
2 participants
No description provided.