Skip to content

[infra/docker] Fix android build docker image#14961

Merged
hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh:fix_android_docker
Mar 28, 2025
Merged

[infra/docker] Fix android build docker image#14961
hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh:fix_android_docker

Conversation

@hseok-oh
Copy link
Contributor

This commit updates the Dockerfile including buildtools for android target runtime build

  • Change android tools install path to /opt/android-tools: root user (github action) cannot read /home/ubuntu
  • Remove packages for format checking: they are not used in android build

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com


Draft: #14758

This commit updates the Dockerfile including buildtools for android target runtime build
- Change android tools install path to /opt/android-tools: root user (github action) cannot read /home/ubuntu
- Remove packages for format checking: they are not used in android build

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Mar 27, 2025
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@hseok-oh hseok-oh merged commit 21effac into Samsung:master Mar 28, 2025
7 checks passed
@hseok-oh hseok-oh deleted the fix_android_docker branch March 28, 2025 00:55
# setup adb server
EXPOSE 5037

WORKDIR /home/ubuntu
Copy link
Contributor

@glistening glistening Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for note:

@hseok-oh told me that this line is not for CI agent, but for someone who uses this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants