Skip to content

[onert-micro/onert-micro] Add kernels for logical operations (And/Or/Not)#15109

Merged
chunseoklee merged 1 commit intoSamsung:masterfrom
monoamind:onert-micro-v2-new-kernels
Jul 27, 2025
Merged

[onert-micro/onert-micro] Add kernels for logical operations (And/Or/Not)#15109
chunseoklee merged 1 commit intoSamsung:masterfrom
monoamind:onert-micro-v2-new-kernels

Conversation

@monoamind
Copy link
Contributor

@monoamind monoamind commented Apr 9, 2025 •
edited
Loading

This will add kernels for logical operations with corresponding tests.

ONE-DCO-1.0-Signed-off-by: Denis Tarasenko monoamind@outlook.com

@chunseoklee
Copy link
Contributor

chunseoklee commented Apr 10, 2025

@monoamind Could you please create PR for refactoring code(e.g. std::array) in another PR ?

@monoamind monoamind force-pushed the onert-micro-v2-new-kernels branch from 30474e4 to 5f6405c Compare April 10, 2025 12:56
@monoamind monoamind changed the title [onert-micro/onert-micro] Add CumSum and logical (And/Or/Not) kernels (DRAFT) [onert-micro/onert-micro] Add kernels for logical operations (And/Or/Not) Apr 10, 2025
@monoamind monoamind marked this pull request as ready for review April 10, 2025 13:00
@monoamind
Copy link
Contributor Author

monoamind commented Apr 10, 2025

@monoamind Could you please create PR for refactoring code(e.g. std::array) in another PR ?

@chunseoklee
Hi, I've updated this PR, now it only includes new kernels for logical operations: And/Or/Not (and corresponding tests).
I will move other changes to a couple of new separate PRs and will reference them here later.

@monoamind monoamind force-pushed the onert-micro-v2-new-kernels branch from 5f6405c to a1aa5d3 Compare April 10, 2025 13:39
@monoamind
Copy link
Contributor Author

monoamind commented Apr 10, 2025 •
edited
Loading

@monoamind Could you please create PR for refactoring code(e.g. std::array) in another PR ?

@chunseoklee
Opened three related PRs (see below).

Fixes and code cleanup for Mean/ReduceProd/Sum kernels:
#15142

CumSum kernel implementation and tests:
#15143

Refactoring and code cleanup for OMRuntimeShape:
#15154

@monoamind monoamind force-pushed the onert-micro-v2-new-kernels branch from a1aa5d3 to 27feb75 Compare May 28, 2025 11:02
@monoamind monoamind force-pushed the onert-micro-v2-new-kernels branch from 27feb75 to 2c2d2bc Compare May 29, 2025 12:57
@monoamind
Copy link
Contributor Author

monoamind commented May 29, 2025

@Torrero
Updated.

Torrero
Torrero approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SlavikMIPT
SlavikMIPT approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monoamind
[onert-micro/onert-micro] Add kernels for logical operations (And/Or/…
1bcb09a 
…Not)

This will add kernels for logical operations with corresponding tests.

ONE-DCO-1.0-Signed-off-by: Denis Tarasenko monoamind@outlook.com
@monoamind monoamind force-pushed the onert-micro-v2-new-kernels branch from 2c2d2bc to 1bcb09a Compare July 24, 2025 09:52
@monoamind
Copy link
Contributor Author

monoamind commented Jul 24, 2025

@chunseoklee
Hi, could you take a look, please?

@chunseoklee chunseoklee merged commit 51776c2 into Samsung:master Jul 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Torrero Torrero Torrero approved these changes

@chunseoklee chunseoklee chunseoklee approved these changes

@SlavikMIPT SlavikMIPT SlavikMIPT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@monoamind @chunseoklee @Torrero @SlavikMIPT