Skip to content

[circle-mlir/dialect] Adaptor with OpaqueProperties#15160

Merged
seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark:cm_dialect_adapt_prop
Apr 15, 2025
Merged

[circle-mlir/dialect] Adaptor with OpaqueProperties#15160
seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark:cm_dialect_adapt_prop

Conversation

@seanshpark
Copy link
Contributor

@seanshpark seanshpark commented Apr 14, 2025

This will revise Conv2D, Reshape to construct Adaptor with OpaqueProperties.

@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark requested a review from a team April 14, 2025 09:39
@shs-park
Copy link
Contributor

This will revise Conv2D, Reshape to ctor Adaptor with OpaqueProperties.

Question, what does ctor mean?

@seanshpark
Copy link
Contributor Author

Question, what does ctor mean?

ah... constructor... looks not correct meaning. updated the comment.

This will revise Conv2D, Reshape to construct Adaptor with OpaqueProperties.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
@seanshpark seanshpark force-pushed the cm_dialect_adapt_prop branch from cde9e24 to d0d9387 Compare April 14, 2025 22:33
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit b11cce8 into Samsung:master Apr 15, 2025
5 checks passed
@seanshpark seanshpark deleted the cm_dialect_adapt_prop branch April 15, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments