Skip to content

[circle-mlir] Apply ONNX-MLIR upgrade#15169

Merged
seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark:cm_reflect_up_mlir
Apr 16, 2025
Merged

[circle-mlir] Apply ONNX-MLIR upgrade#15169
seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark:cm_reflect_up_mlir

Conversation

@seanshpark
Copy link
Contributor

This will add changes for ONNX-MLIR and llvm-project upgrade.
Most of the changes are from llvm-project changes.

@seanshpark
Copy link
Contributor Author

@shs-park
Copy link
Contributor

Now I've just triggered a workflow building new docker image.
Let's wait and retry the PR check then.

@shs-park
Copy link
Contributor

I've just updated the Docker image manually.
Let's try re-running the PR check.

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanshpark,
After docker image updated, it gets onnx2circle_value_test error.

        Start 104: onnx2circle_value_test_Add_F32_R4
104/521 Test #104: onnx2circle_value_test_Add_F32_R4 .....................................***Failed    0.10 sec
======================================================================
Run /__w/ONE/ONE/circle-mlir/build/Release/circle-mlir/tools-test/onnx2circle-value-test/exec_onnx.py /__w/ONE/ONE/circle-mlir/build/Release/circle-mlir/tools-test/onnx2circle-value-test/Add_F32_R4.onnx
Traceback (most recent call last):
  File "/__w/ONE/ONE/circle-mlir/build/Release/circle-mlir/tools-test/onnx2circle-value-test/exec_onnx.py", line 6, in <module>
    import h5py
  File "/usr/local/lib/python3.10/dist-packages/h5py/__init__.py", line 25, in <module>
    from . import _errors
  File "h5py/_errors.pyx", line 1, in init h5py._errors
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

        Start 105: onnx2circle_value_test_Add_F32_R4_C1
105/521 Test #105: onnx2circle_value_test_Add_F32_R4_C1 ..................................***Failed    0.10 sec
======================================================================

This will add changes for ONNX-MLIR and llvm-project upgrade.
Most of the changes are from llvm-project changes.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
@shs-park
Copy link
Contributor

Re-running PR checks with the docker image of #15173

@shs-park
Copy link
Contributor

There are many warnings 😭

...

/__w/ONE/ONE/circle-mlir/circle-mlir/lib/pass/src/ops/HardSigmoidOp.h:61:45: warning: 'bool mlir::Type::isa() const [with Tys = {mlir::NoneType}]' is deprecated: Use mlir::isa<U>() instead [-Wdeprecated-declarations]
   61 |     if (alpha2.getType().isa<mlir::NoneType>())
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from /workdir/include/mlir/IR/AttributeSupport.h:18,
                 from /workdir/include/mlir/IR/Attributes.h:12,
                 from /workdir/include/mlir/Bytecode/BytecodeImplementation.h:17,
                 from /workdir/include/mlir/Bytecode/BytecodeOpInterface.h:17,
                 from /workdir/include/mlir/IR/BuiltinOps.h:16,
                 from /workdir/include/mlir/Dialect/Func/Transforms/Passes.h:17,
                 from /__w/ONE/ONE/circle-mlir/circle-mlir/lib/pass/src/ConvertONNXToCirclePass.h:20,
                 from /__w/ONE/ONE/circle-mlir/circle-mlir/lib/pass/src/ConvertONNXToCirclePass.cpp:18:
/workdir/include/mlir/IR/Types.h:331:6: note: declared here

...

@shs-park
Copy link
Contributor

Anyway all checks have passed
=)

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark
Copy link
Contributor Author

There are many warnings 😭

Yes, warnings are from generated codes from *.td,
and the generator is circle-mlir/lib/tools/converter-gen/converter_gen.cc, from TF :)

@seanshpark
Copy link
Contributor Author

@shs-park thanks! :)

@seanshpark seanshpark merged commit 4becc84 into Samsung:master Apr 16, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments