[circle-mlir] Apply ONNX-MLIR upgrade#15169
Merged
seanshpark merged 1 commit intoSamsung:masterfrom Apr 16, 2025
Merged
Conversation
Contributor
Author
Contributor
|
Now I've just triggered a workflow building new docker image. |
Contributor
|
I've just updated the Docker image manually. |
shs-park
reviewed
Apr 16, 2025
Contributor
shs-park
left a comment
There was a problem hiding this comment.
@seanshpark,
After docker image updated, it gets onnx2circle_value_test error.
Start 104: onnx2circle_value_test_Add_F32_R4
104/521 Test #104: onnx2circle_value_test_Add_F32_R4 .....................................***Failed 0.10 sec
======================================================================
Run /__w/ONE/ONE/circle-mlir/build/Release/circle-mlir/tools-test/onnx2circle-value-test/exec_onnx.py /__w/ONE/ONE/circle-mlir/build/Release/circle-mlir/tools-test/onnx2circle-value-test/Add_F32_R4.onnx
Traceback (most recent call last):
File "/__w/ONE/ONE/circle-mlir/build/Release/circle-mlir/tools-test/onnx2circle-value-test/exec_onnx.py", line 6, in <module>
import h5py
File "/usr/local/lib/python3.10/dist-packages/h5py/__init__.py", line 25, in <module>
from . import _errors
File "h5py/_errors.pyx", line 1, in init h5py._errors
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
Start 105: onnx2circle_value_test_Add_F32_R4_C1
105/521 Test #105: onnx2circle_value_test_Add_F32_R4_C1 ..................................***Failed 0.10 sec
======================================================================3a460a4 to
6cfc410
Compare
This will add changes for ONNX-MLIR and llvm-project upgrade. Most of the changes are from llvm-project changes. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
6cfc410 to
0949013
Compare
Contributor
|
Re-running PR checks with the docker image of #15173 |
Contributor
|
There are many warnings 😭 ...
/__w/ONE/ONE/circle-mlir/circle-mlir/lib/pass/src/ops/HardSigmoidOp.h:61:45: warning: 'bool mlir::Type::isa() const [with Tys = {mlir::NoneType}]' is deprecated: Use mlir::isa<U>() instead [-Wdeprecated-declarations]
61 | if (alpha2.getType().isa<mlir::NoneType>())
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from /workdir/include/mlir/IR/AttributeSupport.h:18,
from /workdir/include/mlir/IR/Attributes.h:12,
from /workdir/include/mlir/Bytecode/BytecodeImplementation.h:17,
from /workdir/include/mlir/Bytecode/BytecodeOpInterface.h:17,
from /workdir/include/mlir/IR/BuiltinOps.h:16,
from /workdir/include/mlir/Dialect/Func/Transforms/Passes.h:17,
from /__w/ONE/ONE/circle-mlir/circle-mlir/lib/pass/src/ConvertONNXToCirclePass.h:20,
from /__w/ONE/ONE/circle-mlir/circle-mlir/lib/pass/src/ConvertONNXToCirclePass.cpp:18:
/workdir/include/mlir/IR/Types.h:331:6: note: declared here
... |
Contributor
|
Anyway all checks have passed |
Contributor
Author
Yes, warnings are from generated codes from |
Contributor
Author
|
@shs-park thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add changes for ONNX-MLIR and llvm-project upgrade.
Most of the changes are from llvm-project changes.