Skip to content

[common-artifacts] Set PYTHON_VERSION_MINOR#15315

Merged
seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark:cmnarts_pyvermin
May 8, 2025
Merged

[common-artifacts] Set PYTHON_VERSION_MINOR#15315
seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark:cmnarts_pyvermin

Conversation

@seanshpark
Copy link
Contributor

This will revise to set PYTHON_VERSION_MINOR for cmake version >= 3.12.

@seanshpark
Copy link
Contributor Author

seanshpark commented May 7, 2025

@seanshpark seanshpark requested a review from a team May 7, 2025 09:59
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion,
PTAL
=)

This will revise to set PYTHON_VERSION_MINOR for cmake version >= 3.12.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
Co-authored-by: Seungho Henry Park <shs.park@samsung.com>
@seanshpark seanshpark requested a review from shs-park May 7, 2025 22:44
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!
=)

@seanshpark
Copy link
Contributor Author

seanshpark commented May 8, 2025

landing PR without @dahlinPL approval, as @dahlinPL comment is comment to a comment, not code review

@seanshpark seanshpark merged commit ca4815c into Samsung:master May 8, 2025
7 checks passed
@seanshpark seanshpark deleted the cmnarts_pyvermin branch May 8, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments