[onert] Remove unused tensorinfo function from common module#16193
Merged
hseok-oh merged 1 commit intoSamsung:masterfrom Oct 14, 2025
Merged
[onert] Remove unused tensorinfo function from common module#16193hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh merged 1 commit intoSamsung:masterfrom
Conversation
This commit removes unused and broken tensorinfo() function from the
common Python module.
>>> import onert
>>> onert.tensorinfo()
Traceback (most recent call last):
File ".../onert/common/basesession.py", line 189, in tensorinfo
return infer.nnfw_tensorinfo()
^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'onert.native.libnnfw_api_pybind.infer' has no attribute 'nnfw_tensorinfo'
Removing this function allows to properly use the native tensorinfo
structure from the onert top level module.
>>> import onert
>>> onert.tensorinfo()
<onert.native.libnnfw_api_pybind.tensorinfo object at 0x7601fe0916f0>
ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
arkq
force-pushed
the
python-native-in-top-level
branch
from
8b1021a to
780a5a6
Compare
ragmani
approved these changes
Oct 13, 2025
Contributor
ragmani
left a comment
ragmani
left a comment
There was a problem hiding this comment.
LGTM
Originally we planned to wrap native.libnnfw_api_pybind.tensorinfo, but that never moved forward. Given that, this change looks better than keeping the old code. It simplifies the public API, removes unnecessary indirection, and reduces potential import cycles.
Contributor
|
Do you have any plan to additionally implement tensorinfo wapper? |
Contributor
Author
|
As for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes unused and broken tensorinfo() function from the common Python module.
Removing this function allows to properly use the native tensorinfo structure from the onert top level module.
ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy a.bokowy@samsung.com