Skip to content

[onert] Remove layer_idx from op_attention#16279

Merged
glistening merged 2 commits intoSamsung:masterfrom
glistening:rm_attn_layer_idx
Nov 13, 2025
Merged

[onert] Remove layer_idx from op_attention#16279
glistening merged 2 commits intoSamsung:masterfrom
glistening:rm_attn_layer_idx

Conversation

@glistening
Copy link
Contributor

@glistening glistening commented Nov 11, 2025

It removes lyaer_idx from Attention Param.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee sg5.lee@samsung.com

I forgot to remove layer_idx from Param.

Related: #16055 (comment)

It removes lyaer_idx from Attention Param.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
@glistening glistening requested a review from hseok-oh November 11, 2025 07:23
@glistening glistening added the approval: 1 Require at least 1 approval label Nov 11, 2025
hseok-oh
hseok-oh previously approved these changes Nov 12, 2025
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) Do you have plan to add new Param's field? Otherwise, we can remove Param struct.

@glistening glistening merged commit d57bf22 into Samsung:master Nov 13, 2025
10 checks passed
@glistening glistening deleted the rm_attn_layer_idx branch November 13, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: 1 Require at least 1 approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments