Skip to content

[luci] Support more dtypes in ForwardTransposeOp#16373

Merged
glistening merged 1 commit intoSamsung:masterfrom
mhs4670go:fix
Feb 5, 2026
Merged

[luci] Support more dtypes in ForwardTransposeOp#16373
glistening merged 1 commit intoSamsung:masterfrom
mhs4670go:fix

Conversation

@mhs4670go
Copy link
Collaborator

This commit supports more dtypes in ForwardTransoseOp pass.

ONE-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com

This commit supports more dtypes in ForwardTransoseOp pass.

ONE-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
@mhs4670go mhs4670go requested a review from a team February 4, 2026 04:07
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

return reverse_transposed_t<loco::DataType::FLOAT32>(node, t);
case loco::DataType::FLOAT16:
return reverse_transposed_t<loco::DataType::FLOAT16>(node, t);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it inteded line break?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. I just split it according to the float vs. int. It's just a preference.

return has_single_element_t<loco::DataType::FLOAT32>(node);
case loco::DataType::FLOAT16:
return has_single_element_t<loco::DataType::FLOAT16>(node);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@mhs4670go mhs4670go requested a review from batcheu February 4, 2026 06:44
@glistening glistening merged commit c643f66 into Samsung:master Feb 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants