Conversation
mhs4670go
reviewed
Feb 5, 2026
Comment on lines
94
to
96
| self.k_proj.wrapped.module.weight = torch.nn.Parameter( | ||
| self.k_proj.wrapped.module.weight * scale_t | ||
| ) |
Contributor
There was a problem hiding this comment.
How about go with in-place updates? It would be safer in PyTorch environment.
with torch.no_grad():
lin = self.k_proj.wrapped.module.weight
lin.weight.mul_(scale_t)
if lin.bias is not None:
lin.bias.mul_(scale_t)This PR folds static scale to `k_proj` to reduce number of `Mul` operations. TICO-DCO-1.0-Signed-off-by: s.malakhov <s.malakhov@partner.samsung.com>
e24ffdd to
df885ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR folds static scale to
k_projto reduce number ofMuloperations.Running `quantize_full_qmodel_with_gptq.py` from #436 for `SmolLM`:
which is almost the same as before
./ccex test -k quantization.wrapq.wrappers.llama.test_quant_attn
which includes
test_forward_diffwith estimation of output differenceDraft: #436
TICO-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com