fixing tracing logic and adding inhomogenous, nonlinear wave eq test for staggered grid#353
Open
cmhyett wants to merge 2 commits intoSciML:masterfrom
Open
fixing tracing logic and adding inhomogenous, nonlinear wave eq test for staggered grid#353cmhyett wants to merge 2 commits intoSciML:masterfrom
cmhyett wants to merge 2 commits intoSciML:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
===========================================
- Coverage 84.99% 62.16% -22.84%
===========================================
Files 41 41
Lines 1959 1953 -6
===========================================
- Hits 1665 1214 -451
- Misses 294 739 +445 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Fixes #352. Attempted to make the code a bit more robust to possibility of shuffling variables.
Test solves the inhomogenous gas flow equations:

\rho_t + \phi_x = 0
\phi_t + a^2 \rho_x = -\beta |\phi|\phi/\rho
(Instabilities are created at long times as shown in figure, but I think this should be related to #351 and so I will not attempt to solve here.